Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone-catalog #531

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Conversation

AvramenkoMarina
Copy link

@AvramenkoMarina AvramenkoMarina commented Nov 8, 2024

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@AvramenkoMarina AvramenkoMarina changed the title add task solution Need a help Nov 9, 2024
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not fixed, feel free to ask for some help in the chat

@AvramenkoMarina AvramenkoMarina changed the title Need a help Phone-catalog Nov 10, 2024
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

  1. Add a favicon on the page
image
  1. When we choose another product, the page should automatically scroll up
image
  1. Add transition when the menu appears on the page
image
  1. The slider should work when we swipe the image, but now nothing happens
image

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. handle plural it should be 2 items but 1 item
    image
  2. not implemented
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants